Skip to content

Conversation

@BinduSri-6522866
Copy link
Contributor

@BinduSri-6522866 BinduSri-6522866 commented Sep 25, 2025

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

Patch rubygem-rexml for CVE-2025-58767
Patch Modified: Yes

  • Patch was backported for /lib/rexml/parsers/baseparser.rb due to version mismatch between existing rubygem-rexml and available upstream Patch.
  • Astrolabe Patch Reference: ruby/rexml@5859bde
Change Log
  • new file: SPECS/rubygem-rexml/CVE-2025-58767.patch
  • modified: SPECS/rubygem-rexml/rubygem-rexml.spec
Does this affect the toolchain?

NO

Links to CVEs
Test Methodology
  • Local build
  • Patch applies cleanly
image - Build is successful

rubygem-rexml-3.3.9-2.azl3.src.rpm.log

@BinduSri-6522866 BinduSri-6522866 requested a review from a team as a code owner September 25, 2025 08:27
@BinduSri-6522866 BinduSri-6522866 marked this pull request as draft September 25, 2025 08:27
@microsoft-github-policy-service microsoft-github-policy-service bot added Packaging 3.0-dev PRs Destined for AzureLinux 3.0 labels Sep 25, 2025
@Kanishk-Bansal
Copy link
Contributor

Buddy Build

@BinduSri-6522866 BinduSri-6522866 marked this pull request as ready for review September 25, 2025 11:12
@BinduSri-6522866
Copy link
Contributor Author

Buddy build passed.

Copy link
Contributor

@bhagyapathak bhagyapathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good

@Kanishk-Bansal Kanishk-Bansal added the ready-for-stable-review PR has passed initial review and is now ready for a second-level stable maintainer review label Sep 29, 2025
Copy link
Contributor

@kgodara912 kgodara912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please check and incorporate #14758 (review)

@BinduSri-6522866
Copy link
Contributor Author

Updated.

@kgodara912 kgodara912 self-requested a review October 25, 2025 05:15
@kgodara912
Copy link
Contributor

Buddy build after recent inclusion of ruby changes.

Copy link
Contributor

@kgodara912 kgodara912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Buddy build is successful. Test cases for rubygem-rexml are verified by developer. As we are not using bundled rexml in ruby instead using separate rexml, ruby version bump is needed. LGTM.

@kgodara912 kgodara912 merged commit 39a9d85 into microsoft:3.0-dev Oct 25, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.0-dev PRs Destined for AzureLinux 3.0 Packaging ready-for-stable-review PR has passed initial review and is now ready for a second-level stable maintainer review security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants